Category Archives: Bad Code

Powershell Bad Code #1: Replacing values in hashtable not working

Question: Why this code is not replacing values (9 with 90) in the hashtable ? Not working Working Answer:

# Answer:
@($hashtable.GetEnumerator()) | Where-Object -FilterScript {$_.Value -eq 9} | ForEach-Object -Process { $hashtable[$_.Key] = 90 }

# Explanation:
It is not possible to modify the table while iterating over it.
First we need to do the iteration and then the update.

# Answer:

@($hashtable.GetEnumerator()) | Where-Object -FilterScript {$_.Value -eq 9} | ForEach-Object -Process { $hashtable[$_.Key] = 90 }

# Explanation:

It is not possible to modify the table while iterating over it.

First we need to do the iteration and then the update.

Powershell Bad Code #2: Sort-Object not working with filenames

Question: Why this command is not sorting the filenames in ascending order from 1 to 20 ? Not working Working Answer :

# Answer:
Get-ChildItem -Path 'C:\Logs' | Select-Object -Property Name | Sort-Object -Property { ($_.Name -replace '[^\d]', '') -as [int] }

# Explanation:
It is needed to sort the filenames as integers : -as [int]

# Answer:

Get-ChildItem -Path 'C:\Logs' | Select-Object -Property Name | Sort-Object -Property { ($_.Name -replace '[^\d]', '') -as [int] }

# Explanation:

It is needed to sort the filenames as integers : -as [int]

Powershell Bad Code #3: Operator “or” in switch statement

Question: Why this code doesn’t display “Found” if the value of the variable $log is 4797 ? Not working

$log = 4797

switch ($log) 
{
    ((4797) -or (4672)){'Found'}
}

$log = 4797

switch ($log)

{

((4797) -or (4672)){'Found'}

}

Working

# Answer:
$log = 4797

switch ($log) 
{
    {$_ -eq 4797 -or $_ -eq 4672} {'Found'}
}

# Explanation: It is needed to use $_ in the switch statement.

# Answer:

$log = 4797

switch ($log)

{

{$_ -eq 4797 -or $_ -eq 4672} {'Found'}

}

# Explanation: It is needed to use $_ in the switch statement.